Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(modal): add correct card-style modal usage for react #21780

Merged
merged 2 commits into from
Jul 22, 2020

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Jul 17, 2020

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #21773

What is the new behavior?

  • Updated usage to pass in IonRouterOutlet ref

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Jul 17, 2020
@pritamsoni-hsr
Copy link

pritamsoni-hsr commented Jul 18, 2020

this one is not working properly, see this, the app is active again because I set showModal = false using onWillDismiss, and if you'd inspect the DOM, all modals are present in the DOM.

@liamdebeasi
Copy link
Contributor Author

You might need to do routerRef.current.current. React sometimes gives back a nested ref for IonRouterOutlet.

@pritamsoni-hsr
Copy link

@liamdebeasi when modal is presented in card style, color of status bar should change, any plan of adding that to ionic-core?

@liamdebeasi
Copy link
Contributor Author

See #20501

@liamdebeasi liamdebeasi merged commit 03ca0c5 into master Jul 22, 2020
@liamdebeasi liamdebeasi deleted the modal-react branch July 22, 2020 17:49
@pritamsoni-hsr
Copy link

with 5.3.1 update, routerRef.current will work.

@liamdebeasi
Copy link
Contributor Author

I'll make a PR to update the docs. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: IonModal and page transitions on iOS
2 participants