fix(input): check for tabindex and pass it properly to native input #21170
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: fixes #17515
Dev build:
5.1.0-dev.202005041740.7d6b4b5
What is the new behavior?
This is not the best code ever written, but it does work. I can't think of a way to ignore
tabindex
on the main host element without removing it after passing it down. Open for review.tabindex
attribute, pass it down if so and then remove ition-input
is ignored from being tabbed to, but the native input can still be tabbed totabindex
onion-item
and it will pass down to the input in Chrome and Safari ignoring the focus on the item, in Firefox it will tab to the item then the inputDoes this introduce a breaking change?
To test this PR, install based on the project type