Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(tabs): document custom properties #16225

Merged
merged 3 commits into from
Nov 5, 2018
Merged

docs(tabs): document custom properties #16225

merged 3 commits into from
Nov 5, 2018

Conversation

camwiegert
Copy link
Contributor

@camwiegert camwiegert commented Nov 5, 2018 •
edited
Loading

This adds documentation for the custom properties in the new tabs API. The ion-tabs and ion-tab components are mostly style-less, so that leaves ion-tab-bar and ion-tab-button. Note that I skipped documenting tab-button's --badge-end property to suggest we reconsider that naming.

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Nov 5, 2018
@camwiegert
Copy link
Contributor Author

For #14850

@manucorporat manucorporat merged commit fda48a0 into master Nov 5, 2018
@manucorporat
Copy link
Contributor

looking great! merged!

@manucorporat manucorporat deleted the tabs-custom-props-doc branch November 5, 2018 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manucorporat manucorporat Awaiting requested review from manucorporat

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@camwiegert @manucorporat