Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabindex is getting set on both ion-input and the native input #7178

Closed
nickwinger opened this issue Jul 3, 2016 · 7 comments · Fixed by #12043
Closed

Tabindex is getting set on both ion-input and the native input #7178

nickwinger opened this issue Jul 3, 2016 · 7 comments · Fixed by #12043
Assignees

Comments

@nickwinger
Copy link

Hi,

i have 2 problems with ion-input.
First the tabindex gets not only set on the wrapped input but also on the ion-input.
These 2 (redundant) tabindex's break form navigation in browsers.

second the angular form validation classes are not set on the wrapped input field, therefore
form validation is not working at all

@jgw96
Copy link
Contributor

jgw96 commented Jul 3, 2016

Hello, thanks for opening an issue with us! Would you be able to provide a plunker that demonstrates this issue? Thanks for using Ionic!

@jgw96 jgw96 added the needs: reply the issue needs a response from the user label Jul 3, 2016
@jgw96
Copy link
Contributor

jgw96 commented Jul 7, 2016

Hello! As it seems it has been a while since there was any activity on this issue i will be closing it for now. Feel free to comment if you are still running into this issue. Thanks for using Ionic!

@jgw96 jgw96 closed this as completed Jul 7, 2016
@nickwinger
Copy link
Author

just because i don't provide a plunkr in time, does not mean you have a bug here

@nickwinger
Copy link
Author

as you can see in this plunkr:
http://plnkr.co/edit/KwRq17cclcrGIM3EMd8y?p=preview

the tabindex gets set on the ion-input tag AND on the input, it should only be on the input.
This is important for ProgesiveWebApp with tab/keyboard support

@jgw96 jgw96 reopened this Jul 8, 2016
@Ionitron Ionitron removed the needs: reply the issue needs a response from the user label Jul 8, 2016
@penrillian-chrisa
Copy link

+1

@brandyscarney
Copy link
Member

I confirmed the tabindex is an issue still. However, the form classes should be getting set correctly on ion-item, ion-input and input.

@brandyscarney brandyscarney self-assigned this Jan 24, 2017
@brandyscarney brandyscarney changed the title v2 - Ion-input problems Tabindex is getting set on both ion-input and the native input Jan 24, 2017
manucorporat added a commit to manucorporat/ionic that referenced this issue Jun 14, 2017
@ionitron-bot
Copy link

ionitron-bot bot commented Sep 2, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants