Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android Back Button closes modal/action sheet/.. and also navigates back #693

Closed
aderholdst opened this issue Feb 27, 2014 · 3 comments
Closed
Assignees
Milestone

Comments

@aderholdst
Copy link

Hi,

I just upgraded to ionic 0.9.26 (0.9.26-alpha-962) and removed my back button "hack" code as you now (for some time :)) support the hardware button within the framework.

Unfortunately without further tuning now the "navigate back on view stack" and "close modal/sheet"-functionality are both registered as listeners with the backbutton and get activated simultaneously producing unexpected behaviour.

From my point of view, handling this could be a responsibilty of $ionicPlatform where only one callback should be active at a time. Do you agree?

@adamdbradley
Copy link
Contributor

Yes that's a good point, we'll take a look, thanks.

@adamdbradley adamdbradley added this to the 0.10.0 milestone Mar 1, 2014
@adamdbradley adamdbradley self-assigned this Mar 1, 2014
@adamdbradley adamdbradley modified the milestones: 0.10.0, 1.0 Beta Mar 3, 2014
@aderholdst
Copy link
Author

Awesome, works like a charm. Really very inspiring to see the framework
grow :).
Am 06.03.2014 22:17 schrieb "Adam Bradley" [email protected]:

Closed #693 #693 via a491f22a491f22
.

Reply to this email directly or view it on GitHubhttps://github.com//issues/693
.

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 6, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants