Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give all $button-color-text a !default value in _variables.scss #631

Closed
cubez opened this issue Feb 19, 2014 · 5 comments
Closed

Give all $button-color-text a !default value in _variables.scss #631

cubez opened this issue Feb 19, 2014 · 5 comments
Assignees
Milestone

Comments

@cubez
Copy link

cubez commented Feb 19, 2014

This way you can override the text color associated with a background color in your own scss file, without having to edit the _variables.scss file.

@gregaton
Copy link

Or why not just do it for all variables?

@adamdbradley
Copy link
Contributor

Yes, they should all have !default. I'll do this for the next release, thanks.

@adamdbradley adamdbradley added this to the 0.9.26 milestone Feb 19, 2014
@adamdbradley adamdbradley self-assigned this Feb 19, 2014
@cubez
Copy link
Author

cubez commented Feb 19, 2014

No, thank you. :)

@hollingberry
Copy link

Awesome, thank you!

On Wed, Feb 19, 2014 at 1:37 PM, cubez [email protected] wrote:

No, thank you. :)

Reply to this email directly or view it on GitHubhttps://github.com//issues/631#issuecomment-35518475
.

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 6, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants