Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Vue ionic plugin has no type #29659

Closed
3 tasks done
Sukaato opened this issue Jun 25, 2024 · 4 comments · Fixed by #29637 · 4 remaining pull requests
Closed
3 tasks done

bug: Vue ionic plugin has no type #29659

Sukaato opened this issue Jun 25, 2024 · 4 comments · Fixed by #29637 · 4 remaining pull requests
Labels
type: bug a confirmed bug report

Comments

@Sukaato
Copy link
Contributor

Sukaato commented Jun 25, 2024

Prerequisites

Ionic Framework Version

v8.x

Current Behavior

while using .use(IonicVue, {}) on creating vue app, the config object of IonicVue has type and does not provide autocomplete.

Expected Behavior

Has typed Vue plugin to have autocompete

Steps to Reproduce

  • create vue application
  • add @ionic/vue
  • add in main.ts .use(IonicVue, {})

See le config object has no autocomplete

Code Reproduction URL

https://github.com/Sukaato/vue-ionic-plugin-type

Ionic Info

Ionic:

Ionic CLI : 7.2.0
Ionic Framework : @ionic/vue 8.2.2

Capacitor:

Capacitor CLI : 6.1.0
@capacitor/android : not installed
@capacitor/core : 6.1.0
@capacitor/ios : not installed

Utility:

cordova-res : not installed globally
native-run : 2.0.1

System:

NodeJS : v22.3.0 (D:\software\NodeJS\node.exe)
npm : 10.7.0
OS : Windows 10

Additional Information

No response

@reslear
Copy link

reslear commented Jun 26, 2024

same problem
Screenshot 2024-06-26 at 21 51 16

@thetaPC
Copy link
Contributor

thetaPC commented Jun 26, 2024

Thank you for submitting the issue!

I can replicate this and agree that we should update the code to add it. I'll look at your PR this week!

@thetaPC thetaPC added the type: bug a confirmed bug report label Jun 26, 2024
@ionitron-bot ionitron-bot bot removed the triage label Jun 26, 2024
github-merge-queue bot pushed a commit that referenced this issue Jun 28, 2024
…#29637)

Issue number: #29659

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->
while using `.use(IonicVue, {})`, the config object has no autocomplete.

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->
- Add type autocomplete on plugin option in VueJS package.


## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!--
  If this introduces a breaking change:
1. Describe the impact and migration path for existing applications
below.
  2. Update the BREAKING.md file with the breaking change.
3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
See
https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer
for more information.
-->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

Co-authored-by: Julien Vaumoron <[email protected]>
@thetaPC
Copy link
Contributor

thetaPC commented Jun 28, 2024

Thanks for the issue! This has been resolved via your PR and will be available in an upcoming release of Ionic.

@thetaPC thetaPC closed this as completed Jun 28, 2024
Copy link

ionitron-bot bot commented Jul 28, 2024

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Jul 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.