Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh option for scrollview when collection-repeat-width or height changes. #1777

Closed
imsingh opened this issue Jul 12, 2014 · 17 comments
Closed

Comments

@imsingh
Copy link

imsingh commented Jul 12, 2014

Please check this forum post in ionic forum.
http://forum.ionicframework.com/t/setting-collection-item-width-dynamically/6603/7

There must be option to render scrollview on user's will.

Thanks.

@mhartington
Copy link
Contributor

You can resize the scrollview using $ionicScrollDelegate.resize();, does this not help?

@imsingh
Copy link
Author

imsingh commented Jul 23, 2014

Hi @mhartington . See this http://apps.inders.in/ionic/
When You change item per page from dropdown to 2. Width of items is changing but second item is not displaying next to first item and so on. I am calling $ionicScrollDelegate.resize(); on changing item per page.

@imsingh imsingh assigned perrygovier and unassigned mhartington Jul 25, 2014
@mhartington
Copy link
Contributor

Alright, gonna hand this off to @perrygovier

@imsingh
Copy link
Author

imsingh commented Jul 31, 2014

Hi @perrygovier Any Update on issue?

@perrygovier
Copy link
Contributor

not yet, @ajoslin is making some modifications to collection repeat that I'm hoping will help before I spend too much time on it

@ajoslin ajoslin assigned ajoslin and unassigned perrygovier Aug 11, 2014
@ajoslin
Copy link
Contributor

ajoslin commented Aug 11, 2014

OK, it works now. If you resize the scroll view, the collectionRepeat will recalculate itself.

@imsingh
Copy link
Author

imsingh commented Aug 11, 2014

It is good. But There is problem. When I switch to nightly builds for testing this feature. I got error after sliding for a couple of time. Error is "Cannot read property $root of null.

Sliding is working fine with previous version.

@ajoslin
Copy link
Contributor

ajoslin commented Aug 11, 2014

Hm. Interesting... I wasn't getting this earlier, I'll take a look again
and see.

@ajoslin
Copy link
Contributor

ajoslin commented Aug 11, 2014

Not getting this. Are you sure it's not a problem on you end?

@imsingh
Copy link
Author

imsingh commented Aug 11, 2014

Hi @ajoslin . Check this http://apps.inders.in/ionic . After clicking forward arrow button for 4 or 5 times. I am getting this error. If you change the ionic.bundle file from nightly to beta release in index.html. it will work fine.

@ajoslin
Copy link
Contributor

ajoslin commented Aug 13, 2014

Checking this out now.

@ajoslin
Copy link
Contributor

ajoslin commented Aug 13, 2014

Fixed! I just simplified the item reuse process to fix this edge case.

Additionally, you will be able to use slidebox soon for what you're doing now ... I'm refactoring it currently to use collection-repeat underneath.

@imsingh
Copy link
Author

imsingh commented Aug 13, 2014

Looking forward to it.
On Aug 13, 2014 8:21 PM, "Andrew Joslin" [email protected] wrote:

Checking this out now.


Reply to this email directly or view it on GitHub
#1777 (comment).

@imsingh
Copy link
Author

imsingh commented Aug 13, 2014

Great. I am checking it know. Thanks.
On Aug 13, 2014 9:59 PM, "Andrew Joslin" [email protected] wrote:

Fixed! I just simplified the item reuse process to fix this edge case.

Additionally, you will be able to use slidebox soon for what you're doing
now ... I'm refactoring it currently to use collection-repeat underneath.


Reply to this email directly or view it on GitHub
#1777 (comment).

@imsingh
Copy link
Author

imsingh commented Aug 13, 2014

Thanks @ajoslin. It is working flawlessly.

@Sjerd
Copy link

Sjerd commented Sep 11, 2014

Does this also mean i can apply an ng-if to a collectionRepeat now??

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 6, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants