Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4: can't scroll the window in standalone tests #15170

Closed
brandyscarney opened this issue Aug 14, 2018 · 2 comments · Fixed by #15220
Closed

v4: can't scroll the window in standalone tests #15170

brandyscarney opened this issue Aug 14, 2018 · 2 comments · Fixed by #15220

Comments

@brandyscarney
Copy link
Member

brandyscarney commented Aug 14, 2018

Bug Report

Visit a standalone test and try to scroll down.

I think we need to move the CSS rules for body so that they only get applied if ion-app exists. The alternative is to split the extra CSS styles into smaller bundles to include so that we can only include the colors if needed.

screen_shot_2018-08-14_at_12_13_54_pm

@brandyscarney
Copy link
Member Author

@manucorporat Let me know your thoughts on this

manucorporat added a commit that referenced this issue Aug 17, 2018
manucorporat added a commit that referenced this issue Aug 17, 2018
manucorporat added a commit that referenced this issue Aug 29, 2018
manucorporat added a commit that referenced this issue Aug 29, 2018
manucorporat added a commit that referenced this issue Aug 29, 2018
@ionitron-bot
Copy link

ionitron-bot bot commented Sep 28, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant