Skip to content

Commit

Permalink
chore: remove team assignment from codeowners (#27573)
Browse files Browse the repository at this point in the history
Issue number: N/A

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

PRs are first assigned to the team before being assigned to a single
team member. This causes reviews to show up
https://github.com/notifications for everyone even if they are not the
final reviewer.

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- GitHub automatically assigns reviewers now, so I removed the global
Framework team codeowner. All PRs in this repo should have a team member
automatically assigned.

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->
  • Loading branch information
liamdebeasi authored May 30, 2023
1 parent 58d6dae commit 4ddb0a9
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@
# In each subsection folders are ordered first by depth, then alphabetically.
# This should make it easy to add new rules without breaking existing ones.

# Global owners
* @ionic-team/framework

# Frameworks

## Angular
Expand Down Expand Up @@ -56,9 +53,6 @@
/core/src/components/refresher/ @liamdebeasi
/core/src/components/refresher-content/ @liamdebeasi

# Codeowner should own the source, but everyone should own the tests
/core/src/components/**/test/ @ionic-team/framework

# Utilities

/core/src/utils/animation/ @liamdebeasi
Expand Down

0 comments on commit 4ddb0a9

Please sign in to comment.