Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(translation/jp): 20240211 update #3437

Merged
merged 802 commits into from
Feb 28, 2024
Merged

feat(translation/jp): 20240211 update #3437

merged 802 commits into from
Feb 28, 2024

Conversation

rdlabo
Copy link
Collaborator

@rdlabo rdlabo commented Feb 11, 2024 •
edited
Loading

It took a little while, but I followed up the main branch.

liamdebeasi and others added 30 commits October 4, 2023 13:41
@liamdebeasi @sean-perkins
docs: add modules architecture usage (#3151)
38486e5
@liamdebeasi @sean-perkins
docs(angular): add angular standalone syntax to non-playground exampl…
91c0b93 
…es (#3116)
@sean-perkins
fix(angular): standalone guide formatting (#3152)
6f194e7
@thetaPC @sean-perkins
docs(angular): include add diff sign (#3157)
ffb5380
@averyjohnston
docs(toast): add playground for positionAnchor (#3158)
a26ba83
@sean-perkins
chore: resolve cspell errors (#3165)
85c3921 
* chore: resolve cspell errors

* chore: ignore all node_modules folders

* chore: adjust sorting
@sean-perkins
docs(select): keyboard navigation (#3156)
60e1778
@renovate
chore(deps): update dependency vue-tsc to v1.8.14 (#3159)
6eea516 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
fix(deps): update dependency web-vitals to v3 (#3142)
45528f6 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@liamdebeasi
chore: team is requested for review for renovatebot prs (#3168)
d3f43b0
@rdlabo
Merge branch 'main' of github.com:ionic-team/ionic-docs
cfbe8ba 
# Conflicts:
#	docs/angular/testing.md
#	docs/api/checkbox.md
#	docs/api/datetime.md
#	docs/api/fab.md
#	docs/api/input.md
#	docs/api/item.md
#	docs/api/modal.md
#	docs/api/radio.md
#	docs/api/select.md
#	docs/api/toggle.md
#	docs/components.md
#	docs/core-concepts/what-are-progressive-web-apps.md
#	docs/react/navigation.md
#	docs/react/pwa.md
#	docs/theming/advanced.md
#	docs/vue/overview.md
#	docs/vue/quickstart.md
#	package-lock.json
#	package.json
@rdlabo
fix typo
2f5fc80
@rdlabo
chore
7b19aff
@rdlabo
chore
645ddb7
@renovate
fix(deps): update dependency vue-router to v4.2.5 (#3147)
7746e0a 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
fix(deps): update dependency @types/react to v18.2.22 (#3141)
397f526 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency vue-tsc to v1.8.15 (#3170)
de551df 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
fix(deps): update dependency @types/node to v18.18.3 (#3171)
014bb88 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency @vitejs/plugin-vue to v4.4.0 (#3172)
8f9e0be 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
fix(deps): update ionic to v7.4.3 (#3178)
aa20560 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
fix(deps): update react monorepo (#3179)
a019fea 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
fix(deps): update dependency web-vitals to v3.5.0 (#3173)
d80acbd 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@mapsandapps
chore: team is requested for review for renovatebot lockfile prs (#3180)
42b1c29
@renovate
chore(deps): update dependency vite to v4.4.11 (#3177)
f3fae69 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@averyjohnston
feat(playground): persist framework and mode selection (#3169)
6fba80d
@renovate
fix(deps): update dependency @types/node to v18.18.4 (#3182)
6c5c0be 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency vue-tsc to v1.8.16 (#3181)
9914d65 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@averyjohnston
fix(playground): wait until playground is in view before loading stor…
3e4a34c 
…ed framework/mode (#3185)
@liamdebeasi
docs(menu): clarify multiple side menu behavior (#3186)
1e392de
@liamdebeasi
chore: release ionic 7.5 docs
5996a81 
chore: release ionic 7.5 docs
@rdlabo rdlabo requested a review from a team as a code owner February 11, 2024 03:04
@rdlabo rdlabo requested review from liamdebeasi and removed request for a team February 11, 2024 03:04
@vercel Vercel
Copy link

vercel bot commented Feb 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2024 3:56am

@rdlabo rdlabo enabled auto-merge (squash) February 11, 2024 03:18
liamdebeasi
liamdebeasi suggested changes Feb 12, 2024
View reviewed changes
scripts/api-ja.js
@@ -0,0 +1,236 @@
// const fetch = require('node-fetch');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this file if we don't need it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it can now be deleted. It can also be removed from the current build script.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I should have asked this originally, but can you clarify why we don't need this script anymore? In main it looks like we still use it:

ionic-docs/scripts/i18n.sh

Line 8 in e9c3e62

node scripts/api-ja.js

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, remove from main branch will not effect. Files no longer in use now.

However, this issue needs to be discussed: #3096

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification!

@liamdebeasi
Copy link
Contributor

Thanks for getting this up to date!

liamdebeasi
liamdebeasi approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rdlabo rdlabo merged commit a4b02e7 into translation/jp Feb 28, 2024
4 checks passed
@rdlabo rdlabo deleted the translation/jp-20240211 branch February 28, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamdebeasi liamdebeasi liamdebeasi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.