Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(skeleton-text): use component name for files #2523

Merged
merged 9 commits into from
Sep 1, 2022
Merged

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Sep 1, 2022

The skeleton text demos were being added to app.component.html which overrides the injected ion-app. This PR fixes that so skeleton text demos get added to the app-example component instead.

Also fixed file names to be more consistent with the other playgrounds.

@vercel
Copy link

vercel bot commented Sep 1, 2022

Deployment failed with the following error:

Invalid vercel.json file provided

@liamdebeasi liamdebeasi marked this pull request as ready for review September 1, 2022 17:57
@liamdebeasi liamdebeasi closed this Sep 1, 2022
@liamdebeasi liamdebeasi reopened this Sep 1, 2022
@vercel
Copy link

vercel bot commented Sep 1, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ionic-docs ✅ Ready (Inspect) Visit Preview Sep 1, 2022 at 6:59PM (UTC)

static/usage/skeleton-text/theming/index.md Outdated Show resolved Hide resolved
static/usage/skeleton-text/theming/index.md Outdated Show resolved Hide resolved
static/usage/skeleton-text/theming/index.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants