Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli-framework/network): change 0.0.0.0 to 127.0.0.1 #3476

Merged
merged 2 commits into from
Aug 3, 2018
Merged

fix(cli-framework/network): change 0.0.0.0 to 127.0.0.1 #3476

merged 2 commits into from
Aug 3, 2018

Conversation

rdlabo
Copy link
Contributor

@rdlabo rdlabo commented Aug 3, 2018 •
edited
Loading

if check host connection, not use 0.0.0.0. Maybe DevApp not use this method.

Fix: #3473

@rdlabo rdlabo requested a review from imhoffd as a code owner August 3, 2018 01:10
@rdlabo
Copy link
Contributor Author

rdlabo commented Aug 3, 2018

Mumu... Local tests is passed.

lerna success run Ran npm script 'test' in packages:
lerna success - @ionic/cli-framework
lerna success - @ionic/cli-utils
lerna success - @ionic/discover
lerna success - @ionic/v1-toolkit
lerna success - cli-scripts
lerna success - ionic

@imhoffd
Copy link
Contributor

imhoffd commented Aug 3, 2018

DevApp does not use this method. This is simply used to block code execution until a connection to the dev server is established.

@imhoffd imhoffd merged commit 12c3f35 into ionic-team:develop Aug 3, 2018
@rdlabo rdlabo mentioned this pull request Aug 6, 2018
Closed
@rdlabo rdlabo deleted the change_127 branch August 8, 2018 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imhoffd imhoffd imhoffd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rdlabo @imhoffd