Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(project): reflect --ssl option. #3437

Closed
wants to merge 1 commit into from

Conversation

rdlabo
Copy link
Contributor

@rdlabo rdlabo commented Jul 30, 2018

ionic serve --ssl will make ng run app:serve --host=0.0.0.0 --port=8100 --ssl.

Fixes #3432

@rdlabo rdlabo requested a review from imhoffd as a code owner July 30, 2018 06:50
@rdlabo rdlabo changed the title fix(project): reflect --ssl option. #3432 fix(project): reflect --ssl option. Jul 30, 2018
@imhoffd
Copy link
Contributor

imhoffd commented Jul 30, 2018

I believe the Angular CLI now requires --ssl-cert and --ssl-key as of version 6, otherwise it appears to generate an SSL certificate at some unknown location and then the user is presented with this:

image

I'd rather we document a proper strategy for HTTPS in our docs using a long-lived SSL certificate that is trusted by their system. I already started work on ionic ssl generate: https://beta.ionicframework.com/docs/cli/ssl-generate

@imhoffd
Copy link
Contributor

imhoffd commented Aug 2, 2018

Subscribe to this issue for updates on HTTPS support: #3305

@imhoffd
Copy link
Contributor

imhoffd commented Aug 2, 2018

This is all possible today by manually passing the SSL args to the Angular CLI:

ionic serve -- --ssl --ssl-cert=/path/to/cert --ssl-key=/path/to/key

The issue I linked above is how Ionic can make it even easier.

@rdlabo
Copy link
Contributor Author

rdlabo commented Aug 2, 2018

thanks! this is great!!

@rdlabo rdlabo closed this Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants