Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release option #16

Closed
mlynch opened this issue Mar 27, 2014 · 10 comments
Closed

Add release option #16

mlynch opened this issue Mar 27, 2014 · 10 comments

Comments

@mlynch
Copy link
Contributor

mlynch commented Mar 27, 2014

We could have a release option that removes unnecessary files and strips everything down.

@somethingnew2-0
Copy link

What is unnecessary?

@mlynch
Copy link
Contributor Author

mlynch commented Mar 27, 2014

All of the angular bower includes, the non-minified Ionic code, etc.

On Thu, Mar 27, 2014 at 12:00 AM, Peter C [email protected] wrote:

What is unnecessary?


Reply to this email directly or view it on GitHubhttps://github.com//issues/16#issuecomment-38769275
.

@ibes
Copy link

ibes commented Jun 8, 2014

Would be nice.
Otherwise there will be much unnecessary stuff in the build app, right?

(I am new to ionic and building apps)

@adamdbradley
Copy link

I think that could be dangerous and could build some broken apps. While dev's shouldn't be editing lib files that you'd think could be safely removed, I would imagine it will still happen. And if our tool is removing some stuff automatically, it'll have no way of accurately knowing what it should and shouldn't remove.

@omeid
Copy link

omeid commented Jul 25, 2014

@adamdbradley I am not sure if that is an issue, if devs change a lib the changes will be reflected in the minfied files, so removing or keep the original shouldn't have any effect.

@adamdbradley
Copy link

I mean the end developer, not Ionic developers. I'm saying that if a developer (not a core ionic developer) decided to hack away at www/lib/ionic/ionic.js, or they added in their own file in that folder, we can't safely say what should be removed or not. We won't know where everyone is putting files that make their app run, so to try to automatically remove unnecessary code I think will randomly cause apps to break and it'll be extremely difficult for end developers to debug once it's built into corodva land.

@fizerkhan
Copy link

I think, it is necessary. I build 4 apps without realising that my apk(android) has unnecessary files. Then i removed them manually. The size is reduced from 10MB to 2MB. It is huge difference. It is kind of repeated task for every app that i am going to build.

I hope, lot of developers face the same issue. Ionic build process should handle this automatically.

At least, Inform developers to remove unnecessary files or what can be removed in Publishing your app

@jbavari jbavari added this to the 1.3.1 milestone Dec 31, 2014
@jbavari jbavari modified the milestones: 1.3.2, 1.3.1 Jan 12, 2015
@jbavari jbavari modified the milestone: 1.3.3 Jan 29, 2015
@okonon
Copy link

okonon commented Feb 4, 2015

this might be related to #168
Don't you think?

@jbavari
Copy link

jbavari commented Mar 23, 2015

This is being discussed in Issue #270 by another user Luis. We may be incorporating his changes for this there.

@jthoms1
Copy link
Contributor

jthoms1 commented Apr 8, 2016

Thanks for opening the issue. It seems that issue has been resolved. I am going to close this issue but please feel free to reopen another issue if this occurs again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants