-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release option #16
Comments
What is unnecessary? |
All of the angular bower includes, the non-minified Ionic code, etc. On Thu, Mar 27, 2014 at 12:00 AM, Peter C [email protected] wrote:
|
Would be nice. (I am new to ionic and building apps) |
I think that could be dangerous and could build some broken apps. While dev's shouldn't be editing lib files that you'd think could be safely removed, I would imagine it will still happen. And if our tool is removing some stuff automatically, it'll have no way of accurately knowing what it should and shouldn't remove. |
@adamdbradley I am not sure if that is an issue, if devs change a lib the changes will be reflected in the minfied files, so removing or keep the original shouldn't have any effect. |
I mean the end developer, not Ionic developers. I'm saying that if a developer (not a core ionic developer) decided to hack away at |
I think, it is necessary. I build 4 apps without realising that my apk(android) has unnecessary files. Then i removed them manually. The size is reduced from 10MB to 2MB. It is huge difference. It is kind of repeated task for every app that i am going to build. I hope, lot of developers face the same issue. Ionic build process should handle this automatically. At least, Inform developers to remove unnecessary files or what can be removed in Publishing your app |
this might be related to #168 |
This is being discussed in Issue #270 by another user Luis. We may be incorporating his changes for this there. |
Thanks for opening the issue. It seems that issue has been resolved. I am going to close this issue but please feel free to reopen another issue if this occurs again. |
We could have a release option that removes unnecessary files and strips everything down.
The text was updated successfully, but these errors were encountered: