This repository was archived by the owner on May 1, 2020. It is now read-only.
feat(replacePathVars): support interpolation of objects and arrays #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…us4/ionic-app-scripts into feature/replacePathVars
…into feature/replacePathVars # Conflicts: # src/spec/util.spec.ts
|
Am I seeing things, or did you move much of the content from Thanks, |
|
@danbucholtz i think something happened during the merge as i had a conflict. Ill have a look |
|
@danbucholtz should be all good now, apologies! |
|
@danbucholtz you think we can have this merged please? |
|
Sorry, this is kind of hard to follow. Can you start fresh with master and make your changes? There is a huge merge in the middle here. Then I will merge it. Copy and paste should be fine so it shouldn't take too much work to do. Sorry for the inconvience! Thanks, |
|
@danbucholtz new PR #449 |
|
Thanks @alan-agius4, much better and easier to read! Thanks, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Refactor replacePathVars to support Arrays, Objects and Strings
Fixes: #238