This repository has been archived by the owner on May 1, 2020. It is now read-only.
Preserve original linterOptions in tslint.json #1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tslint.json may specify linterOptions. For example, a certain directory may be excluded from linting. However, when linter is run as part of ionic-app-scripts, linterOptions are fully overwritten, and exclusion is no longer performed. This changelist addresses the problem above by preserving original linterOptions, and extending them with the requested ones.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
tslint.json may specify linterOptions.
For example, a certain directory may be excluded from linting.
However, when linter is run as part of ionic-app-scripts, linterOptions
are fully overwritten, and exclusion is no longer performed.
Changes proposed in this pull request:
This changelist addresses the problem above by preserving original
linterOptions, and extending them with the requested ones.