Skip to content
This repository has been archived by the owner on May 1, 2020. It is now read-only.

add more directory to ANDROID_PLATFORM_PATH #1393

Conversation

adityapurwa
Copy link

@adityapurwa adityapurwa commented Feb 18, 2018

Short description of what this resolves:

There is a bug when we run ionic cordova run/emulate android --livereload, somehow the system won't notice that cordova is available on the device. This fix will allow the system to notice that cordova is available when using --livereload.

The fix method is taken from ionic-team/ionic-cli#2973.

Changes proposed in this pull request:

  • Change the ANDROID_PLATFORM_PATH from export const ANDROID_PLATFORM_PATH = path.join('platforms', 'android', 'assets', 'www');
  • Replace it with export const ANDROID_PLATFORM_PATH = path.join('platforms', 'android', 'app', 'src', 'main', 'assets', 'www');

Fixes: #1391

@imhoffd
Copy link
Contributor

imhoffd commented Feb 21, 2018

@adityapurwa For more insight on the issue, please read this: #1380

We can't just change the path. There needs to be some detection of which version of cordova-android they're using.

@adityapurwa
Copy link
Author

I suppose this fix will only applicable if Ionic updated its major version thus introducing non backward compatible changes but fully support cordova 7. I will try to find a way to detects the cordova version too so this fix could be applied on non major updates too.

@itslenny
Copy link
Contributor

Hi, @adityapurwa I just opened #1407 to try to address this. Sorry, if you already had a solution. I didn't see this PR until after I added mine.

@imhoffd
Copy link
Contributor

imhoffd commented Apr 18, 2018

@adityapurwa Thanks for digging into this and fixing the issue! I appreciate it greatly. Unfortunately, to keep backwards compatibility, I merged @itslenny's PR (#1407) instead, so I'll close this issue.

@imhoffd imhoffd closed this Apr 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

livereload doesn't work with native plugins
3 participants