-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ios): fix keyboard displacement bug in iOS 12 WKWebView #201
fix(ios): fix keyboard displacement bug in iOS 12 WKWebView #201
Conversation
I'm seeing a "bounce" effect when completing a particular input and then programmatically focusing the next. This might need to be de-bounced or handled with some better state handling for that use-case. |
…ring programmatic focus toggling
Worked in the timer debounce support for the programmatic input-focus issue (which caused a visual "bouncing" during an unnecessary @KhanhPhamDinh - you might want to take a look to see how this differs from your original implementation. |
Your welcome, @booleanbetrayal. |
Any change on getting this merged @dwieeb / @nphyatt? There is a good explanation of the issue in apache/cordova-ios#417 prior to realizing this was an Apple WKWebView issue we'd need to work around. Thanks! |
Note that there's detailed information on this |
@booleanbetrayal using this fork did solve the viewport problem in iOS. But convertFileSrc() has undefined error in android application. If I switch back to master branch of the WKWEBVIEW, convertFileSrc() works fine in android. |
@simtechpom - perhaps a discrepancy between when I forked this repo and what master is at now. Out of scope from this changeset. All the more reason to get this merged! |
Please merge this. I'm facing issues with the keyboard. Whenever I type into a textarea the back button stops working |
@manucorporat Could you please take a look at this and possibly merge? it basically renders our app useless and is a huge issue. Thanks in advance. |
So who has tested this? Just because it's a PR doesn't mean that you can't start using it. Would love some help making sure this doesn't break stuff. |
I've not tested this patch yet Max, but I just dowgraded my keyboard plugin to the deprecated version and it works fine there:
Not really sure why it doens't happen there 🤷♂️
and cordova plugin
|
Okay resolved conflicts and merged. Testing something quick and then will be in 2.2.4 tonight |
2.2.4 released with this PR, thanks for the contribution and for others adding their feedback! |
I just tried |
Great! Hopefully this gets fixed upstream on Apple's end at some point and we can limit the scope of those keyboard listeners. |
Still happens to me with webview 2.2.5 and keyboard 2.1.3 installed. Specifically when focusing on an input in a login screen in Framework7. Elements get pushed top and at keyboard closing the height isn't adjusted |
I am finding that it isn't working for me either. I tried with webview 2.2.5 & 2.2.4 and using keyboard 2.2.1. Same experience as @risikoruk |
I am also still experiencing this issue using cordova-plugin-ionic-webview 2.3.1 and cordova-plugin-ionic-keyboard 2.1.3 |
I'm on cordova-plugin-ionic-webview 2.3.2 and can still reproduce this issue, but I'm not using any keyboard plugin |
I am on cordova-plugin-ionic-webview 4.0.0 and this is still an issue. |
I have the same issue and it's show stopper |
Downgrading to |
Issue still exists in ios12 with Ionic 4 wkwebview. |
Fixes #176
credit: @KhanhPhamDinh