Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run dispatch-release.yaml in 6.x branch #7736

Closed
wants to merge 1 commit into from
Closed

Conversation

jcesarmobile
Copy link
Member

I've created a 6.x branch in ionic-team/capacitor-swift-pm for Capacitor 6, make the 6.x Capacitor branch run the workflow in 6.x branch too

@Steven0351
Copy link
Member

Steven0351 commented Oct 24, 2024

This shouldn't be needed, this workflow runs when a tag is pushed, not when a commit is made to main. The target repo checks out the version specified and builds that, there isn't anything specific to any version of capacitor in that repo.

@jcesarmobile
Copy link
Member Author

Both Capacitor and Capacitor plugins are pointing to "main", which at the moment is Capacitor 7 alpha 1, I've created a 6.x branch in ionic-team/capacitor-swift-pm pointing to latest 6.x release and sent PRs to Capacitor and Capacitor Plugins 6.x branch to make them use 6.x branch instead of main, but we need that whenever we publish a new 6.x version it's published on the 6.x branch, not in main branch, and I though this change would do that, but not sure how ionic-team/capacitor-swift-pm publishing works and if this change will have that effect. If this doesn't make the publish action in ionic-team/capacitor-swift-pm repo to publish on main, we will have to change the action code in 6.x branch to publish in 6.x branch.

#7737
ionic-team/capacitor-plugins#2221

@Steven0351
Copy link
Member

Steven0351 commented Oct 24, 2024

A simpler approach would be to just have a version range in the Package.swift to be 6.0.0 < 7.0.0. I'm not sure why every Package.swift was just pointing directly to main.

@Steven0351
Copy link
Member

@markemer do you know why the Package.swift's have been pointing to main?

@jcesarmobile
Copy link
Member Author

Ok, will update to use ranges or from and delete the 6.x branch from ionic-team/capacitor-swift-pm repo

@jcesarmobile jcesarmobile deleted the 6x-spm branch October 24, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants