Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): expose methodName via CAPPluginCall #7641

Merged
merged 8 commits into from
Sep 27, 2024

Conversation

robingenz
Copy link
Contributor

Close #7476

@markemer
Copy link
Member

markemer commented Sep 4, 2024

Yeah - so this is a pretty breaking change - we'd need to have both versions of the plugin call or do this in a more subtle way.

@robingenz
Copy link
Contributor Author

Why is it a breaking change? Who else creates instances of CAPPluginCall? Or am I missing something obvious?

@markemer
Copy link
Member

markemer commented Sep 4, 2024

Why is it a breaking change? Who else creates instances of CAPPluginCall? Or am I missing something obvious?

You may be right actually - I think I was looking at this a bit early in the morning here - let me double check, I think I was been confusing it with a different function.

@markemer
Copy link
Member

markemer commented Sep 4, 2024

Yeah, these are available publicly - I don't think anyone is using them - but leaving the old version with a deprecation tag makes some sense - and we can just set it to blank or "unknown" in case someone does use it.

Edit: I can add that real fast if you don't mind me messing with your branch.

@robingenz
Copy link
Contributor Author

Edit: I can add that real fast if you don't mind me messing with your branch.

Yes, feel free to make the changes. 🙌

@robingenz
Copy link
Contributor Author

@markemer I have added the old version with a deprecation tag again. Let me know if you need any other changes.

Copy link
Member

@Steven0351 Steven0351 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Steven0351 Steven0351 merged commit df109aa into ionic-team:main Sep 27, 2024
6 checks passed
Steven0351 added a commit that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: expose methodName via CAPPluginCall
4 participants