-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): expose methodName
via CAPPluginCall
#7641
Conversation
Yeah - so this is a pretty breaking change - we'd need to have both versions of the plugin call or do this in a more subtle way. |
Why is it a breaking change? Who else creates instances of |
You may be right actually - I think I was looking at this a bit early in the morning here - let me double check, I think I was been confusing it with a different function. |
Yeah, these are available publicly - I don't think anyone is using them - but leaving the old version with a deprecation tag makes some sense - and we can just set it to blank or "unknown" in case someone does use it. Edit: I can add that real fast if you don't mind me messing with your branch. |
Yes, feel free to make the changes. 🙌 |
@markemer I have added the old version with a deprecation tag again. Let me know if you need any other changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
… (#7684) Co-authored-by: Robin Genz <[email protected]>
Close #7476