Fix for Capacitor issue 7596, remove fragment from allowedOrigin #7597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the `server.url` contains a fragment, then the `allowedOrigin` rule is not valid and the WebView will not inject plugin javascript. This manifests as the javascript runtime in the WebView reporting that `Capacitor.platform` is `web` instead of `android` and plugin calls within the `WebView` failing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
server.urlcontains a fragment, then theallowedOriginrule is not valid and the WebView will not inject plugin javascript. This manifests as the javascript runtime in the WebView reporting thatCapacitor.platformiswebinstead ofandroidand plugin calls within theWebViewfailing.This is a fix for #7596