fix(cli): Run sync before updating gradle #7497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
requested review from
IT-MikeS,
markemer,
andredestro,
EiyuuZack,
theproducer and
nflsilva
markemer
approved these changes
Jun 5, 2024
vmfo22
approved these changes
Jun 6, 2024
This was referenced Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the Android project is in not buildable state, gradle will fail to update the files because the project needs to build to update gradle.
Running npx cap sync before updating the gradle files will generate other non committed gradle files that are needed to build the project and that are not there in case the project was just checked out from github and never ran npx cap sync before on the project.
Also error the migration if npx cap sync failed to run, getCommandOutput doesn't error and reports the command as a success despite it failed, by using runCommand instead, it will fail the migration if npx cap sync fails.
closes #7489