Fix parsing non-object JSON response in CapacitorHttp plugin #6224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to fetch/xhr without encoding as json.
build native-bridge
|
@JanMisker Can you resolve these conflicts? Seems like this solves our issue, but our 204 response handling update caused a conflict. I can move and fix it if you want, but fixing this one will give you the credit in contributors since this is your first PR against the repo. |
|
Check I will do it today or tomorrow, thanks for considering my credits 🤓 |
|
@markemer I resolved the conflicts, thanks for reviewing. |
|
One more ask. Can you run |
markemer
requested review from
ItsChaceD,
markemer,
giralte-ionic,
IT-MikeS,
theproducer and
jcesarmobile
giralte-ionic
approved these changes
Mar 22, 2023
markemer
approved these changes
Mar 22, 2023
markemer
added a commit
that referenced
this pull request
Apr 17, 2023
Co-authored-by: Mark Anderson <[email protected]>
|
Is there an ETA on when this will be taken up in a release? |
|
It should be in the current capacitor 5.0 RC. I'm not sure of the GA of Capacitor 5, other than soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following valid json
"hello world"is not handled correctly in the CapacitorHttp core plugin. This PR fixes that, although on Android there might be some improvements possible.
See https://github.com/JanMisker/Capacitor-JSONParseError for a simple app that reproduces this error.