Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add capacitor run command #3599

Merged
merged 39 commits into from
Oct 16, 2020
Merged

feat(cli): add capacitor run command #3599

merged 39 commits into from
Oct 16, 2020

Conversation

imhoffd
Copy link
Contributor

@imhoffd imhoffd commented Sep 22, 2020

TODO:

  • iOS
  • native-run installation instructions when not found
  • more error handling

closes #3142
depends on #3565

imhoffd and others added 24 commits September 9, 2020 15:50
Conflicts:
	cli/src/android/add.ts
	cli/src/android/common.ts
	cli/src/android/doctor.ts
	cli/src/android/open.ts
	cli/src/android/update.ts
	cli/src/common.ts
	cli/src/config.ts
	cli/src/cordova.ts
	cli/src/index.ts
	cli/src/ios/add.ts
	cli/src/ios/common.ts
	cli/src/ios/doctor.ts
	cli/src/ios/open.ts
	cli/src/ios/update.ts
	cli/src/plugin.ts
	cli/src/tasks/add.ts
	cli/src/tasks/copy.ts
	cli/src/tasks/create.ts
	cli/src/tasks/doctor.ts
	cli/src/tasks/init.ts
	cli/src/tasks/list.ts
	cli/src/tasks/new-plugin.ts
	cli/src/tasks/open.ts
	cli/src/tasks/serve.ts
	cli/src/tasks/sync.ts
	cli/src/tasks/update.ts
	cli/src/web/copy.ts
	cli/test/util.ts
Co-authored-by: jcesarmobile <[email protected]>
Conflicts:
	cli/src/android/update.ts
	cli/src/common.ts
	cli/src/config.ts
	cli/src/definitions.ts
	cli/src/ios/common.ts
	cli/src/tasks/add.ts
Conflicts:
	cli/src/android/common.ts
	cli/src/android/doctor.ts
	cli/src/common.ts
	cli/src/config.ts
	cli/src/ios/common.ts
@imhoffd imhoffd added this to the 3.0.0 milestone Sep 22, 2020
Conflicts:
	cli/src/android/common.ts
	cli/src/android/doctor.ts
	cli/src/common.ts
	cli/src/ios/common.ts
	cli/src/ios/update.ts
@imhoffd imhoffd marked this pull request as ready for review September 29, 2020 22:39
@imhoffd imhoffd requested a review from jcesarmobile October 13, 2020 00:55
cli/src/common.ts Outdated Show resolved Hide resolved
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a minor comment.

For future PRs would be good if they stick to adding just the functionality and not doing a major refactor as it makes extremely hard to review and focus on the important changes.

@imhoffd imhoffd requested a review from jcesarmobile October 15, 2020 19:25
@imhoffd imhoffd merged commit 8576b0f into main Oct 16, 2020
@imhoffd imhoffd deleted the run-command branch October 16, 2020 15:42
imhoffd added a commit that referenced this pull request Oct 16, 2020
@imhoffd imhoffd mentioned this pull request Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add capacitor run command
2 participants