fix: 204 http response (#6266)

ionic-team · Mar 20, 2023 · 771f6ce · 771f6ce
1 parent 76202ca
commit 771f6ce
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 3 deletions.
diff --git a/android/capacitor/src/main/assets/native-bridge.js b/android/capacitor/src/main/assets/native-bridge.js
@@ -384,9 +384,13 @@ var nativeBridge = (function (exports) {
                                 data: (options === null || options === void 0 ? void 0 : options.body) ? options.body : undefined,
                                 headers: headers,
                             });
-                            const data = typeof nativeResponse.data === 'string'
+                            let data = typeof nativeResponse.data === 'string'
                                 ? nativeResponse.data
                                 : JSON.stringify(nativeResponse.data);
+                            // use null data for 204 No Content HTTP response
+                            if (nativeResponse.status === 204) {
+                                data = null;
+                            }
                             // intercept & parse response before returning
                             const response = new Response(data, {
                                 headers: nativeResponse.headers,

diff --git a/core/native-bridge.ts b/core/native-bridge.ts
@@ -437,10 +437,16 @@ const initBridge = (w: any): void => {
               },
             );
 
-            const data =
+            let data =
               typeof nativeResponse.data === 'string'
                 ? nativeResponse.data
                 : JSON.stringify(nativeResponse.data);
+
+            // use null data for 204 No Content HTTP response
+            if (nativeResponse.status === 204) {
+              data = null;
+            }
+
             // intercept & parse response before returning
             const response = new Response(data, {
               headers: nativeResponse.headers,

diff --git a/ios/Capacitor/Capacitor/assets/native-bridge.js b/ios/Capacitor/Capacitor/assets/native-bridge.js
@@ -384,9 +384,13 @@ var nativeBridge = (function (exports) {
                                 data: (options === null || options === void 0 ? void 0 : options.body) ? options.body : undefined,
                                 headers: headers,
                             });
-                            const data = typeof nativeResponse.data === 'string'
+                            let data = typeof nativeResponse.data === 'string'
                                 ? nativeResponse.data
                                 : JSON.stringify(nativeResponse.data);
+                            // use null data for 204 No Content HTTP response
+                            if (nativeResponse.status === 204) {
+                                data = null;
+                            }
                             // intercept & parse response before returning
                             const response = new Response(data, {
                                 headers: nativeResponse.headers,