fix(http): copy native response url to fetch response

ionic-team · Apr 6, 2023 · 42d2eb3 · 42d2eb3
1 parent aa52296
commit 42d2eb3
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 0 deletions.
diff --git a/android/capacitor/src/main/assets/native-bridge.js b/android/capacitor/src/main/assets/native-bridge.js
@@ -392,6 +392,14 @@ var nativeBridge = (function (exports) {
                                 headers: nativeResponse.headers,
                                 status: nativeResponse.status,
                             });
+                            /*
+                             * copy url to response, `cordova-plugin-ionic` uses this url from the response
+                             * we need `Object.defineProperty` because url is an inherited getter on the Response
+                             * see: https://stackoverflow.com/a/57382543
+                             * */
+                            Object.defineProperty(response, 'url', {
+                                value: nativeResponse.url,
+                            });
                             console.timeEnd(tag);
                             return response;
                         }

diff --git a/core/native-bridge.ts b/core/native-bridge.ts
@@ -447,6 +447,15 @@ const initBridge = (w: any): void => {
               status: nativeResponse.status,
             });
 
+            /*
+             * copy url to response, `cordova-plugin-ionic` uses this url from the response
+             * we need `Object.defineProperty` because url is an inherited getter on the Response
+             * see: https://stackoverflow.com/a/57382543
+             * */
+            Object.defineProperty(response, 'url', {
+              value: nativeResponse.url,
+            });
+
             console.timeEnd(tag);
             return response;
           } catch (error) {

diff --git a/ios/Capacitor/Capacitor/assets/native-bridge.js b/ios/Capacitor/Capacitor/assets/native-bridge.js
@@ -392,6 +392,14 @@ var nativeBridge = (function (exports) {
                                 headers: nativeResponse.headers,
                                 status: nativeResponse.status,
                             });
+                            /*
+                             * copy url to response, `cordova-plugin-ionic` uses this url from the response
+                             * we need `Object.defineProperty` because url is an inherited getter on the Response
+                             * see: https://stackoverflow.com/a/57382543
+                             * */
+                            Object.defineProperty(response, 'url', {
+                                value: nativeResponse.url,
+                            });
                             console.timeEnd(tag);
                             return response;
                         }