Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route path is the literal name of the page #48

Closed
imhoffd opened this issue Dec 19, 2018 · 1 comment
Closed

Route path is the literal name of the page #48

imhoffd opened this issue Dec 19, 2018 · 1 comment
Labels
bug Something isn't working released

Comments

@imhoffd
Copy link
Contributor

imhoffd commented Dec 19, 2018

❯ ionic g page "Hello World"
> ng generate page "Hello World"
CREATE src/app/hello-world/hello-world.module.ts (564 bytes)
CREATE src/app/hello-world/hello-world.page.scss (0 bytes)
CREATE src/app/hello-world/hello-world.page.html (138 bytes)
CREATE src/app/hello-world/hello-world.page.spec.ts (720 bytes)
CREATE src/app/hello-world/hello-world.page.ts (275 bytes)
UPDATE src/app/app-routing.module.ts (470 bytes)
[OK] Generated page!
❯ git diff
diff --git a/src/app/app-routing.module.ts b/src/app/app-routing.module.ts
index 41f546e..28c56f4 100644
--- a/src/app/app-routing.module.ts
+++ b/src/app/app-routing.module.ts
@@ -4,6 +4,7 @@ import { Routes, RouterModule } from '@angular/router';
 const routes: Routes = [
   { path: '', redirectTo: 'home', pathMatch: 'full' },
   { path: 'home', loadChildren: './home/home.module#HomePageModule' },
+  { path: 'Hello World', loadChildren: './hello-world/hello-world.module#HelloWorldPageModule' },
 ];

 @NgModule({
@imhoffd imhoffd added the bug Something isn't working label Dec 19, 2018
@Ionitron
Copy link
Collaborator

🎉 This issue has been resolved in version 1.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

wand1252 added a commit to wand1252/angular-toolkit-develop that referenced this issue Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

No branches or pull requests

2 participants