Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to use custom builder #32

Closed
imhoffd opened this issue Oct 30, 2018 · 1 comment
Closed

Ability to use custom builder #32

imhoffd opened this issue Oct 30, 2018 · 1 comment
Labels
bug Something isn't working released

Comments

@imhoffd
Copy link
Contributor

imhoffd commented Oct 30, 2018

Right now the cordova-build builder is hard-coded to use @angular-devkit/build-angular:browser:

angular-toolkit/builders/cordova-build/index.ts

Line 16 in 7bc2839

const browserBuilder = new BrowserBuilder(this.context); // TODO: shouldn't this use `architect.getBuilder()`?

We should be able to use architect.getBuilder() to instantiate a builder from the workspace configuration.
@imhoffd imhoffd added the enhancement New feature or request label Oct 30, 2018
@imhoffd imhoffd mentioned this issue Oct 30, 2018
Closed
@imhoffd imhoffd added bug Something isn't working and removed enhancement New feature or request labels Dec 19, 2018
@Ionitron
Copy link
Collaborator

🎉 This issue has been resolved in version 1.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@doug-a-brunner doug-a-brunner mentioned this issue Mar 27, 2019
Closed
wand1252 added a commit to wand1252/angular-toolkit-develop that referenced this issue Aug 31, 2022
@wand1252 @adamclerk
fix(build): respect browserTarget setting
27132e6 
This enables the ability to use a custom builder in the cordova-build
builder.

Fixes ionic-team/angular-toolkit#32

Co-authored-by: Adam Clark <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@imhoffd @Ionitron