fix(generators): update path builder (#275)

make sure path builder sets the options correctly Closes #274
ionic-team · Aug 24, 2020 · 1393e8c · 1393e8c
1 parent f7fb5c6
commit 1393e8c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/schematics/component/index.ts b/schematics/component/index.ts
@@ -130,13 +130,11 @@ export default function(options: ComponentOptions): Rule {
 
     const workspace = await getWorkspace(host);
     const project = workspace.projects.get(options.project);
-
-    let optPath = '';
     if (project && options.path === undefined) {
-      optPath = buildDefaultPath(project);
+      options.path = buildDefaultPath(project);
     }
 
-    const parsedPath = parseName(optPath, options.name);
+    const parsedPath = parseName(options.path as string, options.name);
     options.name = parsedPath.name;
     options.path = parsedPath.path;
     options.selector = options.selector ? options.selector : buildSelector(options, project?.prefix ?? 'app');

diff --git a/schematics/page/index.ts b/schematics/page/index.ts
@@ -186,14 +186,13 @@ export default function(options: PageOptions): Rule {
 
     const workspace = await getWorkspace(host);
     const project = workspace.projects.get(options.project);
-    let optPath = '';
     if (project && options.path === undefined) {
-      optPath = buildDefaultPath(project);
+      options.path = buildDefaultPath(project);
     }
 
     options.module = findRoutingModuleFromOptions(host, options);
 
-    const parsedPath = parseName(optPath, options.name);
+    const parsedPath = parseName(options.path as string, options.name);
     options.name = parsedPath.name;
     options.path = parsedPath.path;
     options.selector = options.selector ? options.selector : buildSelector(options, project?.prefix ?? 'app');