Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix on_emg_data() callback #16

Merged
merged 3 commits into from
Jun 22, 2023
Merged

Fix on_emg_data() callback #16

merged 3 commits into from
Jun 22, 2023

Conversation

iomz
Copy link
Owner

@iomz iomz commented Jun 22, 2023

This PR implements #15.

@iomz iomz added the enhancement New feature or request label Jun 22, 2023
@iomz iomz self-assigned this Jun 22, 2023
@iomz iomz linked an issue Jun 22, 2023 that may be closed by this pull request
design: trigger on_emg_data with EMGData type, not the 8-byte list (just 1 sample each) #15
Closed
@codecov
Copy link

codecov bot commented Jun 22, 2023 •
edited
Loading

Codecov Report

Merging #16 (8c723b6) into main (c721fa8) will increase coverage by 21.42%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main      #16       +/-   ##
===========================================
+ Coverage   64.55%   85.98%   +21.42%     
===========================================
  Files          10        7        -3     
  Lines         663      371      -292     
  Branches       54       16       -38     
===========================================
- Hits          428      319      -109     
+ Misses        231       48      -183     
  Partials        4        4
Impacted Files Coverage Δ
myo/__init__.py 100.00% <100.00%> (ø)
tests/test_myo/test_types.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@iomz iomz merged commit 87f1ebc into main Jun 22, 2023
@iomz iomz deleted the refactor-test-coverage branch June 22, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@iomz iomz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

design: trigger on_emg_data with EMGData type, not the 8-byte list (just 1 sample each)
1 participant
@iomz