Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: make test-ci output TAP to stdout and log #938

Closed
wants to merge 0 commits into from

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Feb 24, 2015

Roughly the same as #810 but removes message from test-ci so we can actually use it. Produce TAP output and write a test.tap file so Jenkins can pick it up.

R= @bnoordhuis
R= @jbergstroem

@bnoordhuis
Copy link
Member

LGTM

rvagg added a commit that referenced this pull request Feb 24, 2015
@rvagg rvagg closed this Feb 24, 2015
@rvagg rvagg deleted the test-ci-tap branch February 24, 2015 19:29
@rvagg
Copy link
Member Author

rvagg commented Feb 24, 2015

@rvagg rvagg mentioned this pull request Feb 24, 2015
@rvagg rvagg mentioned this pull request Feb 24, 2015
@rvagg
Copy link
Member Author

rvagg commented Feb 25, 2015

@bnoordhuis @indutny can you have a look at some of the runs after this merge, e.g. https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/193/

Is the -J a problem here? If I run without -J does parallel actually do anything parallel? It looks to me like perhaps all of the test types are being run in parallel here hence the errors with sockets and pipes.

petkaantonov pushed a commit to petkaantonov/io.js that referenced this pull request Feb 25, 2015
@indutny
Copy link
Member

indutny commented Feb 25, 2015

@rvagg could be related to a stray process that I see locally after make test?

@indutny
Copy link
Member

indutny commented Feb 25, 2015

@rvagg this is what I see after make test:

$ ps ax | grep iojs
99139 s003  S      0:00.00 /bin/sh -c "/Users/indutny/Code/indutny/node/out/Release/iojs" "/Users/indutny/Code/indutny/node/test/parallel/test-stdio-closed.js" child 1>&- 2>&-
99140 s003  R      0:00.03 /Users/indutny/Code/indutny/node/out/Release/iojs /Users/indutny/Code/indutny/node/test/parallel/test-stdio-closed.js child
99142 s003  R+     0:00.00 grep iojs

@indutny
Copy link
Member

indutny commented Feb 25, 2015

@bnoordhuis this seems to be your thing b5f25a9

@bnoordhuis
Copy link
Member

@indutny It is and I'm seeing that too, FWIW. I'll take a look.

bnoordhuis added a commit to bnoordhuis/io.js that referenced this pull request Feb 25, 2015
Fix parallel/test-stdio-closed introduced in commit b5f25a9 ("src:
ensure that file descriptors 0-2 are valid") to not keep spawning
child processes ad infinitum.

The test spawns itself as a child process but a missing return statement
made the child process spawn itself again, and again, and again.

It went unnoticed for some time because the child process exits almost
immediately afterwards, i.e. it didn't fill up the process table.  The
observable effect was an iojs process that was quietly consuming CPU
cyles in the background with a PID that was constantly changing.

Refs: nodejs#938
PR-URL: nodejs#948
Reviewed-By: Fedor Indutny <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants