Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

js2c: fix module id generation on windows #1281

Merged
merged 1 commit into from
Mar 27, 2015

Conversation

bnoordhuis
Copy link
Member

Fix a regression that was introduced in commit 2db758c ("iojs: introduce
internal modules") where the computed id for "config.gypi" on Windows
was not "config" but an empty string.

With an empty string, the build succeeds but the binary is unusable:
startup.processConfig() in src/node.js chokes on the missing .config
property.

R=@vkurchatkin

https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/385/

@bnoordhuis
Copy link
Member Author

I'm off to bed so someone please land this if it LGTY and the CI is happy.

@vkurchatkin
Copy link
Contributor

LGTM if CI is ok. I'm wondering how it compiles with an empty string as a module name.

@Fishrock123
Copy link
Contributor

I think CI is ok. Not familiar with smartos failure, but seems unrelated. Timeouts: also probably not related (to this or the original commit).

@jbergstroem
Copy link
Member

Yeah, smartos is unrelated.

@mscdex mscdex added windows Issues and PRs related to the Windows platform. build Issues and PRs related to build files or the CI. labels Mar 27, 2015
Fix a regression that was introduced in commit 2db758c ("iojs: introduce
internal modules") where the computed id for "config.gypi" on Windows
was not "config" but an empty string.

With an empty string, the build succeeds but the binary is unusable:
startup.processConfig() in src/node.js chokes on the missing .config
property.

PR-URL: nodejs#1281
Reviewed-By: Vladimir Kurchatkin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants