Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Attachment to org package #443

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added Attachment to org package #443

wants to merge 2 commits into from

Conversation

samlown
Copy link
Collaborator

@samlown samlown commented Dec 7, 2024

Adds support for Attachments that are compliant with the EN16931 specification in invoices.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have added thorough tests with at least 90% code coverage.
  • I've modified or created example GOBL documents the show my changes in use, if appropriate.
  • When adding or modifying a tax regime or addon, I've added links to the source of the changes either structured or in the comments.
  • I've run go generate . to ensure that Schemas and Regime data are up to date.
  • All linter warnings have been reviewed and fixed.
  • I've been obsessive with pointer nil checks to avoid panics.
  • The CHANGELOG.md has been updated with an overview of my changes.
  • Requested a review from @samlown.

Copy link

codecov bot commented Dec 8, 2024

Codecov Report

Attention: Patch coverage is 79.54545% with 9 lines in your changes missing coverage. Please review.

Project coverage is 82.91%. Comparing base (152a0ac) to head (b6adfa3).

Files with missing lines Patch % Lines
addons/eu/en16931/org.go 0.00% 7 Missing ⚠️
addons/eu/en16931/en16931.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           cef-vatex     #443      +/-   ##
=============================================
- Coverage      82.92%   82.91%   -0.02%     
=============================================
  Files            242      244       +2     
  Lines          11897    11941      +44     
=============================================
+ Hits            9866     9901      +35     
- Misses          1671     1680       +9     
  Partials         360      360              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from cef-vatex to main December 12, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant