fix(ui): progress bar not throbbing when it should #7332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we added more progress events during generation, we indirectly broke the logic that controls when the progress bar throbs.
psychedelicious
requested review from
blessedcoolant,
maryhipp and
hipsterusername
as code owners
maryhipp
approved these changes
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When we added more progress events during generation, we indirectly broke the logic that controls when the progress bar throbs.
Related Issues / Discussions
Reported by @Vargol here (thanks!): https://discord.com/channels/1020123559063990373/1149506274971631688/1307136679831928913
QA Instructions
Generate. The bar should throb while loading models and doing anything that doesn't have discrete steps.
Merge Plan
n/a
Checklist