Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing python-socketio dependency #4633

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

Malrama
Copy link
Contributor

@Malrama Malrama commented Sep 21, 2023

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Community Node Submission

Have you discussed this change with the InvokeAI team?

  • Yes
  • No, because: It's mandatory

Have you updated all relevant documentation?

  • Yes
  • No

Description

Since #4552 python-socketio is required as a dependency. It was a dependancy of fastapi-socketio before it got removed.

This resolves the issue of "ModuleNotFoundError: No module named 'socketio'" on a fresh .venv on 3.2.0RC1

Related Tickets & Documents

  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

Added/updated tests?

  • Yes
  • No : please replace this line with details on why tests
    have not been included

[optional] Are there any post deployment tasks we need to perform?

Copy link
Collaborator

@psychedelicious psychedelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch - thanks!

@hipsterusername hipsterusername merged commit b479000 into invoke-ai:main Sep 21, 2023
8 checks passed
@Malrama Malrama deleted the python-socketio-dep branch September 21, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants