Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Removing Default Quick Actions #2262

Merged

Conversation

Civolilah
Copy link
Collaborator

@beganovich @turbo124 The PR includes a fix for displaying default quick actions when no preferences are stored for a specific entity. Let me know your thoughts.

@turbo124
Copy link
Member

@Civolilah

I'm not sure about this. We shouldn't force this one on users, this should be opt in only.

@turbo124 turbo124 added question Further information is requested and removed QA pending labels Dec 12, 2024
@Civolilah
Copy link
Collaborator Author

Civolilah commented Dec 12, 2024

@Civolilah

I'm not sure about this. We shouldn't force this one on users, this should be opt in only.

@turbo124 So, this is how we initially imagined the solution for quick actions - with two default actions - so I just fixed that here. However, if you prefer NOT to have this part of the logic anymore, I can remove it. Let me know what you prefer.

@turbo124
Copy link
Member

@Civolilah

Are you saying that we already set some default actions now without this PR?

@Civolilah
Copy link
Collaborator Author

@Civolilah

Are you saying that we already set some default actions now without this PR?

@turbo124 Exactly, in the very first PR for the Invoice entity we had them implemented, but I made a small logical mistake which caused an issue when the second entity was added to the implementation. That is how we had imagined the solution for the Invoice entity.

@Civolilah Civolilah added QA pending and removed question Further information is requested labels Jan 13, 2025
@Civolilah Civolilah changed the title [Bugfix] Displaying Default Quick Actions [Bugfix] Removing Default Quick Actions Jan 13, 2025
@turbo124 turbo124 requested a review from beganovich January 14, 2025 21:26
@beganovich beganovich merged commit 3abf679 into invoiceninja:develop Jan 15, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants