-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Removing Default Quick Actions #2262
[Bugfix] Removing Default Quick Actions #2262
Conversation
I'm not sure about this. We shouldn't force this one on users, this should be opt in only. |
@turbo124 So, this is how we initially imagined the solution for quick actions - with two default actions - so I just fixed that here. However, if you prefer NOT to have this part of the logic anymore, I can remove it. Let me know what you prefer. |
Are you saying that we already set some default actions now without this PR? |
@turbo124 Exactly, in the very first PR for the Invoice entity we had them implemented, but I made a small logical mistake which caused an issue when the second entity was added to the implementation. That is how we had imagined the solution for the Invoice entity. |
@beganovich @turbo124 The PR includes a fix for displaying default quick actions when no preferences are stored for a specific entity. Let me know your thoughts.