Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: E-Invoice Import #9635

Merged
merged 4 commits into from
Jun 22, 2024
Merged

Conversation

LarsK1
Copy link
Contributor

@LarsK1 LarsK1 commented Jun 12, 2024

No description provided.

@LarsK1
Copy link
Contributor Author

LarsK1 commented Jun 12, 2024

@turbo124 ready for review.

@turbo124
Copy link
Member

@LarsK1 thanks, i'll review after 5.9.6 is released.

routes/api.php Outdated Show resolved Hide resolved
Copy link
Member

@turbo124 turbo124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small change requests

@LarsK1
Copy link
Contributor Author

LarsK1 commented Jun 18, 2024

@turbo124 rebased, please review.

@LarsK1 LarsK1 requested a review from turbo124 June 18, 2024 06:24
routes/api.php Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LarsK1 could you rebase please, it looks like this is overwriting some routes.

Copy link
Member

@turbo124 turbo124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase, otherwise looks ready for merge.

@paulwer
Copy link
Contributor

paulwer commented Jun 21, 2024

@LarsK1 @turbo124 understood.

I require to get the expense back from the job/service to determine, what should happen next. f.ex. create the expense without parsing or add the html document to the expense. Can you may scope the logic for handling multiple doc types into a seperate service, consuming ZugferdEDocument, so i can use the whole implementation as syncronous code?

i wanna point your interest back to the last comment i wrote before merging :)

@LarsK1
Copy link
Contributor Author

LarsK1 commented Jun 21, 2024

@turbo124 rebased and fixed the missing api-route.

@paulwer
Copy link
Contributor

paulwer commented Jun 21, 2024

@LarsK1 @turbo124 understood.
I require to get the expense back from the job/service to determine, what should happen next. f.ex. create the expense without parsing or add the html document to the expense. Can you may scope the logic for handling multiple doc types into a seperate service, consuming ZugferdEDocument, so i can use the whole implementation as syncronous code?

i wanna point your interest back to the last comment i wrote before merging :)

Hi @LarsK1
I offered @turbo124 that i include this minor change in my PR later, if you wanna conclude this PR faster.

@LarsK1
Copy link
Contributor Author

LarsK1 commented Jun 21, 2024

Hi, @paulwer,
that would be awesome. I'm in Holidays until Friday next week...

@paulwer
Copy link
Contributor

paulwer commented Jun 21, 2024

Sounds great, i will therefore wait until @turbo124 has merged to v5-develop :)

@LarsK1 LarsK1 requested a review from turbo124 June 22, 2024 03:52
@turbo124 turbo124 merged commit 0ed2520 into invoiceninja:v5-develop Jun 22, 2024
17 checks passed
@turbo124
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants