-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frankenphp #678
Frankenphp #678
Conversation
benbrummer
commented
Dec 28, 2024
- frankenphp
- Avoids workaround for react updates
- Worker mode for Laravel Octane (invoiceninja needs to be made ready for it)
- gzip, brotli and zstd for static files
- mariadb 11.4 (lts)
- valkey 8 (redis)
- Removes supervisord
- Use separate containers for worker/scheduler
- Use separate containers for worker/scheduler
This looks awesome! My vote for this one would be to create a new branch and build this as an optional image. There will need to be some careful testing around this due to the long lived PHP process approach with octane. |
@turbo124 Do you have a suggestions for the branch-name? Locally I'm already able to run with Laravel Octane, but I have an issue with |
Let's use octane for the branch name, I will include Laravel octane in the dependencies |
|
- ./.env:/app/.env | ||
- ./php/php.ini:/usr/local/etc/php/conf.d/zzz-php.ini:ro |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think having a default zzz-1-php.ini baked in the image would be better?
And users could mount additional ini's to set more or override things like zzz-2-php.ini
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes totaly sense to delivere a base php-file inside the image. Will be integrated with the next PR.
The next time we tag a release, the octane dependency will be automatically handled from the main invoiceninja/invoiceninja repo. |