Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockerfile cleanup, apt reduction, php module configuration, allow to run custom CMD #664

Merged
merged 27 commits into from
Dec 5, 2024

Conversation

benbrummer
Copy link
Collaborator

#660 (comment)

Remove unnecessary php artisan config:cache from init.sh, as it is handled with php artisan optimize

@benbrummer benbrummer requested a review from turbo124 November 29, 2024 12:51
@turbo124
Copy link
Member

@benbrummer for me, when i just pulled in the latest image, the newest react files did not get brought over.

This is because we are not using a volume pointing at public/ even thou it is read only, this excludes the image public directory from being mounted.

@benbrummer
Copy link
Collaborator Author

@benbrummer for me, when i just pulled in the latest image, the newest react files did not get brought over.

This is because we are not using a volume pointing at public/ even thou it is read only, this excludes the image public directory from being mounted.

So the react files should be updated in the volume image_public:/var/www/html/public:ro?

@turbo124
Copy link
Member

@benbrummer

I've created a PR with a new approach here:

#665

this will copy the /public directory of the image to a temp dir, then when the entrypoint script it reach, we'll remove the current js/css files from public/ and copy the contents of the public/ directory over to the volume.

thoughts on this approach?

This is the only way I can think to work around the volume mount being required for the public/ directory and also allowing the newer files in the image to be available.

@benbrummer
Copy link
Collaborator Author

benbrummer commented Dec 1, 2024

  • Only necessary configurations are now done for google-chrome-stable => basically only ownership for /var/www needs to be changed from root => www-data
  • Other "chrome" related configuration is handled in an arm64 specific else
  • Directories\files like tmp, var or related to packages installed by apt e.g supervisor, should not be modified in terms of permissions, if we leave them with default permissions, we could go with a unix socket for php-fpm image
  • Integrated a similar implementation for Update dockerfile #665.
  • Permissions, will be always set/fixed by init.sh
  • uploads folder is now created in init.sh fab57c9#diff-8dd2c51f2415751ba02f093cc2f74858af7a46b65d90541ac5a7f7a5efa6e614R37, but I think it is not used at all?

@benbrummer benbrummer marked this pull request as draft December 2, 2024 08:59
…gned for php 8.3 and 8.4), increased buffernumber to allow parallel requests without writing to file
@benbrummer benbrummer marked this pull request as ready for review December 2, 2024 10:54
- *-dev packages are not required
- fonts depends on libpng16-16 (no dev)
- rename volume according to their origin
- Add arguments for required, suggested and extra php-modules
@benbrummer benbrummer changed the title move google-chrome-stable related packages to arm64 section dockerfile cleanup, apt reduction, php module configuration, allow to run custom CMD Dec 5, 2024
@benbrummer
Copy link
Collaborator Author

Fix for #664

@turbo124 turbo124 merged commit 53c38b6 into invoiceninja:debian Dec 5, 2024
1 check passed
@turbo124
Copy link
Member

turbo124 commented Dec 5, 2024

Thanks for your help on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants