-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dockerfile cleanup, apt reduction, php module configuration, allow to run custom CMD #664
Conversation
@benbrummer for me, when i just pulled in the latest image, the newest react files did not get brought over. This is because we are not using a volume pointing at public/ even thou it is read only, this excludes the image public directory from being mounted. |
So the react files should be updated in the volume image_public:/var/www/html/public:ro? |
I've created a PR with a new approach here: this will copy the /public directory of the image to a temp dir, then when the entrypoint script it reach, we'll remove the current js/css files from public/ and copy the contents of the public/ directory over to the volume. thoughts on this approach? This is the only way I can think to work around the volume mount being required for the public/ directory and also allowing the newer files in the image to be available. |
…default owned by root
…wnership afterwards.
mv public directory inside a single RUN to not increase the image
|
…gned for php 8.3 and 8.4), increased buffernumber to allow parallel requests without writing to file
- *-dev packages are not required - fonts depends on libpng16-16 (no dev)
- rename volume according to their origin - Add arguments for required, suggested and extra php-modules
Signed-off-by: benbrummer <[email protected]>
Fix for #664 |
- Fix if statement
CMD was not properly handled
Thanks for your help on this! |
#660 (comment)
Remove unnecessary
php artisan config:cache
frominit.sh
, as it is handled withphp artisan optimize