-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft:Windows specific prefix check (magick), add support for windows in github actions #555
base: master
Are you sure you want to change the base?
Conversation
Good catch. Thanks for this PR. I just realized that unit tests here on gh, don't test it on windows. |
@bosd sure thing, I'll switch it to draft for now and play around with it :) |
@bosd btw, i've modified the main.yml accordingly. Have been playing around with it on my forked branch and some tests are failing, so i'll keep grinding away at it. I'll probably end up splitting it out , since there seems to be some issues with windows GA running in parallel, where they fail to lock. Anywaz, i'll keep you posted in here once it's ready to review :) |
Thanks for the update. |
Maybe this is of help. Tests are running here correctly on a matrix of ubuntu releases and one windows. |
Yeah, if it's fine to only test against one Python version I would do it like that. Otherwise I would run the windows ones sequentially :) |
Oopsie, It looks like I messed up this PR, while trying to resolve merge conflicts |
Noticed an issue on windows that just using convert isn't correct as it conflicts with a native command in windows. Instead just checking if magick exists should be enough, then convert can be prefixed with that when running the full command. Also ran black for tesseract.py, which unfortunately reformatted some stuff :(