Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft:Windows specific prefix check (magick), add support for windows in github actions #555

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

alexm96
Copy link

@alexm96 alexm96 commented Apr 25, 2024

Noticed an issue on windows that just using convert isn't correct as it conflicts with a native command in windows. Instead just checking if magick exists should be enough, then convert can be prefixed with that when running the full command. Also ran black for tesseract.py, which unfortunately reformatted some stuff :(

@bosd
Copy link
Collaborator

bosd commented Apr 25, 2024

Good catch. Thanks for this PR.
Is it possible to separate the black formatting in a separate commit?

I just realized that unit tests here on gh, don't test it on windows.
Can you add those to gh workflow? 🙏

@alexm96
Copy link
Author

alexm96 commented Apr 25, 2024

@bosd sure thing, I'll switch it to draft for now and play around with it :)

@alexm96 alexm96 changed the title Windows specific prefix check (magick) Draft:Windows specific prefix check (magick) Apr 25, 2024
@alexm96 alexm96 changed the title Draft:Windows specific prefix check (magick) Draft:Windows specific prefix check (magick), add support for windows in github actions Apr 25, 2024
@alexm96
Copy link
Author

alexm96 commented Apr 26, 2024

@bosd btw, i've modified the main.yml accordingly. Have been playing around with it on my forked branch and some tests are failing, so i'll keep grinding away at it. I'll probably end up splitting it out , since there seems to be some issues with windows GA running in parallel, where they fail to lock. Anywaz, i'll keep you posted in here once it's ready to review :)

@bosd
Copy link
Collaborator

bosd commented Apr 26, 2024

Thanks for the update.
Earlier, I made attempt to let the actions run here.
I'll hold off for now, as you can test it on your own repo.

@bosd
Copy link
Collaborator

bosd commented Apr 26, 2024

Maybe this is of help. Tests are running here correctly on a matrix of ubuntu releases and one windows.
https://github.com/py-pdf/pypdf_table_extraction/blob/main/.github/workflows/tests.yml

@alexm96
Copy link
Author

alexm96 commented Apr 26, 2024

Yeah, if it's fine to only test against one Python version I would do it like that. Otherwise I would run the windows ones sequentially :)

@bosd
Copy link
Collaborator

bosd commented Jul 18, 2024

Oopsie, It looks like I messed up this PR, while trying to resolve merge conflicts

@bosd
Copy link
Collaborator

bosd commented Jul 19, 2024

superseeded by #565
@alexm96 Can you help fixing the tests.

Yeah, if it's fine to only test against one Python version I would do it like that.

Sounds like an good idea, Windows tests take a lot of compute and time to complete when running against the full matrix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants