Avoid UnboundLocalError when exception is raised #509
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
continue
to the except block, otherwise anUnboundLocalError: local variable 'tpl' referenced before assignment
is thrown when trying to assigntpl["template_name"] = name
afterjson.loads()
raised an exception.@bosd I think reading the templates should not fail completely because of one invalid template. Maybe we could also be more sensitive about the file types and only try
json.loads
for.json
files instead of every file except .yml files (and for other file types raise a warning that only .yml and .json are supported)? What do you think about this?