tests: custom: verify that missing fields don't get set #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rmilecki
commented
Feb 4, 2023
rmilecki
commented
rmilecki
force-pushed
the
tests-missing-fields
branch
from
c873795
to
2f2803f
Compare
bosd
approved these changes
Feb 4, 2023
It's to prevent breakages like the one fixed by the commit bc667cf ("Don't set empty fields in output"). Signed-off-by: Rafał Miłecki <[email protected]>
bosd
force-pushed
the
tests-missing-fields
branch
from
2f2803f
to
d4e90a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.