Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parsers: lines: display "ignoring (...)" for all unrecognized lines #460

Merged
merged 1 commit into from
Feb 5, 2023

Conversation

rmilecki
Copy link
Collaborator

@rmilecki rmilecki commented Feb 3, 2023

This is very helpful for debugging problems with parsing lines.

This is very helpful for debugging problems with parsing lines.

Signed-off-by: Rafał Miłecki <[email protected]>
@rmilecki
Copy link
Collaborator Author

rmilecki commented Feb 3, 2023

This addresses:

This diff looks quite big, but the real change is if first_line_found is False:if first_line_found is True: and comment update. The rest of diff lines are whitespace changes (indention level).

To review this pull request easily please use git's option -w or GitHub's setting of "Diff view" called "Hide whitespace"

@rmilecki
Copy link
Collaborator Author

rmilecki commented Feb 3, 2023

See actual changes in this pull request:
image

Copy link
Collaborator

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was afraid this would affect the results.
Tests are still passing, so LGTM

@bosd bosd merged commit 55b9bd5 into invoice-x:master Feb 5, 2023
@rmilecki rmilecki mentioned this pull request Feb 6, 2023
@rmilecki rmilecki deleted the lines-print-all-unrecognized-lines branch May 11, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants