-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IOS][LINKS] Apply new restorationHandler implementation #1778
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1778 +/- ##
=======================================
Coverage 76.16% 76.16%
=======================================
Files 72 72
Lines 1838 1838
=======================================
Hits 1400 1400
Misses 438 438 |
3 similar comments
Codecov Report
@@ Coverage Diff @@
## master #1778 +/- ##
=======================================
Coverage 76.16% 76.16%
=======================================
Files 72 72
Lines 1838 1838
=======================================
Hits 1400 1400
Misses 438 438 |
Codecov Report
@@ Coverage Diff @@
## master #1778 +/- ##
=======================================
Coverage 76.16% 76.16%
=======================================
Files 72 72
Lines 1838 1838
=======================================
Hits 1400 1400
Misses 438 438 |
Codecov Report
@@ Coverage Diff @@
## master #1778 +/- ##
=======================================
Coverage 76.16% 76.16%
=======================================
Files 72 72
Lines 1838 1838
=======================================
Hits 1400 1400
Misses 438 438 |
Related PR in react-native facebook/react-native#22764 |
Will this be merged soon? Experiencing same issue, @iljadaderko will be our hero if we can get this working. |
Hi there! I'm helping maintain the v5 branch along with @Salakar and I believe we have CI all sorted and tests green etc so the v5 branch can tolerate change now. If you rebase to current v5.x.x and push this again, I can check into it and try to get it merged for you. @iljadaderko what do you think? |
@mikehardy 👍 I completely forgot about this PR. I'll likely close it tomorrow and will submit new PR with few changes that are needed to support Swift (similar to one I submitted for rn Linking facebook/react-native#22764) |
works for me - thanks! |
Closing in favour of #2216 cc @mikehardy |
Summary
@Salakar this is universal linking issue we talked about with you earlier. Same one I opened react-native issue for facebook/react-native#22716
I basically applied same implementation as apple has documented here https://developer.apple.com/documentation/uikit/uiapplicationdelegate/1623072-application?language=objc
And this fixed issues I was having in XCode 10 / ios 12. I tested this on a real device. I was not able to test with earlier iOS versions, but judging by apple's documentation this should be supported by iOS 8+ and previous implementation used
Any
instead ofUIUserActivityRestoring
, so there shouldn't be any issues here as well. And finallyrestorationHandler
is not used as far as I can tell, it just needs to be passed in.Checklist
Android
iOS
e2e
tests added or updated in /tests/e2e/*Test Plan
Implement the change, check if it works on iOS devices that are running versions lower than 12. Has to be ran on a real device due to nature of simulator.
Release Plan
[IOS][ENHANCEMENT] [LINKS] - Updated universal link handling implementation for iOS 12
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter