Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for @optional dependencies #432

Merged
merged 2 commits into from
Dec 4, 2016
Merged

Support for @optional dependencies #432

merged 2 commits into from
Dec 4, 2016

Conversation

remojansen
Copy link
Member

Description

Support for @optional dependencies 🎉

Related Issue

#411

Motivation and Context

#411

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mention-bot
Copy link

@remojansen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @sanex3339, @lukas-zech-software and @endel to be potential reviewers.

@remojansen remojansen changed the title Support for @optional dependencies 🎉 Support for @optional dependencies Dec 4, 2016
@remojansen remojansen mentioned this pull request Dec 4, 2016
Closed
@remojansen remojansen merged commit 961acc4 into inversify:master Dec 4, 2016
@endel
Copy link
Contributor

endel commented Dec 4, 2016

This will come in handy 👍 👍

@remojansen
Copy link
Member Author

Thanks 😄 Docs available at here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@remojansen @mention-bot @endel