Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements #421 & refactor enum -> literal types #424

Merged
merged 10 commits into from
Nov 29, 2016
Merged

Implements #421 & refactor enum -> literal types #424

merged 10 commits into from
Nov 29, 2016

Conversation

remojansen
Copy link
Member

Description

Implements #421 & refactor enum -> literal types

Related Issue

#421

Motivation and Context

#421

How Has This Been Tested?

Added some extra unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mention-bot
Copy link

@remojansen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @endel and @hourliert to be potential reviewers.

@remojansen remojansen merged commit 44f5f06 into inversify:master Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants