Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix constant value deactivation #1331

Merged
merged 7 commits into from
May 7, 2021
Merged

Fix constant value deactivation #1331

merged 7 commits into from
May 7, 2021

Conversation

tonyhallett
Copy link
Contributor

fix #1330

notaphplover
notaphplover approved these changes May 6, 2021
View reviewed changes
Copy link
Member

@notaphplover notaphplover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

test/resolution/resolver.test.ts Outdated Show resolved Hide resolved
@notaphplover notaphplover merged commit 174866d into inversify:master May 7, 2021
@tonyhallett tonyhallett deleted the fix-constant-value-deactivation branch May 14, 2021 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notaphplover notaphplover notaphplover approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should not deactivate a constant value that has not been activated
2 participants
@tonyhallett @notaphplover