Skip to content

WIP tests: repeated package different extras#6

Closed
david-caro wants to merge 1 commit intoinveniosoftware:masterfrom
david-caro:add_package_extras_handling
Closed

WIP tests: repeated package different extras#6
david-caro wants to merge 1 commit intoinveniosoftware:masterfrom
david-caro:add_package_extras_handling

Conversation

@david-caro
Copy link
Member

  • Adds a test to check the behavior when the same package is listed
    more than once with different extras selected.
  • Adds also ingnories for vim swapfiles.

Signed-off-by: David Caro david@dcaro.es

* Adds a test to check the behavior when the same package is listed
  more than once with different extras selected.
* Adds also ingnories for vim swapfiles.

Signed-off-by: David Caro <david@dcaro.es>
@david-caro david-caro force-pushed the add_package_extras_handling branch from b9c3d41 to 8613258 Compare July 27, 2016 09:16
@jirikuncar jirikuncar changed the title tests: repeated package different extras [WIP] WIP tests: repeated package different extras Jul 27, 2016
@jirikuncar jirikuncar added this to the v0.1.1 milestone Jul 27, 2016
@jirikuncar
Copy link
Member

@david-caro can you keep the .gitignore fixes in separate commit (or even better PR)?

'click>=5.0.0',
'mock>=1.3.0',
'invenio-db[versioning]>=1',
'invenio-db[versioning,mysql]>=1',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO it's more complicated in real life. This case should never happen since it's obvious to fix. There might be however following case:

requirements = [
    'invenio-db[versioning]>=1',
]

extras_require = {
     'mysql': [
          'invenio-db[mysql]>=1',
     ],
}
$ requirements-builder -e mysql ...
invenio-db[versioning,mysql]>=1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but now you see and are able to reproduce the issue, and most probably, the root of it is the same as the real-life example (still investigating).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@david-caro When you re-push, please also add yourself to the AUTHORS.rst file, thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@david-caro IMHO we don't have to solve this limitation here since pip-compile already solves it for us.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pip compile needs a requirements.txt file as input, the step from setup.py->requirements.txt is done by requirements-builder and that step is the one that's failing:

08:36 AM ~/Work/inveniosoftware/invenio-workflows<venv:invenio-workflows>  (starting-point-invenio-3|…7) 
dcaro@pcrcssis001$ grep invenio-db setup.py 
        'invenio-db[postgresql,versioning]>=1.0.0a9',
        'invenio-db[mysql,versioning]>=1.0.0a9',
        'invenio-db[versioning]>=1.0.0a9',
    'invenio-db[versioning]>=1.0.0a9',
08:36 AM ~/Work/inveniosoftware/invenio-workflows<venv:invenio-workflows>  (starting-point-invenio-3|…7) 
dcaro@pcrcssis001$ requirements-builder -e mysql --level=min setup.py
blinker==1.4
flask-celeryext==0.1.0
Flask-CLI==0.2.1
invenio-db==1.0.0a9
invenio-files-rest==1.0.0a3
invenio-records-files==1.0.0a5

@david-caro
Copy link
Member Author

This does not make sense here anymore, as the issue is down the stack trace, on pip pypa/pip#3878

@david-caro david-caro closed this Jul 29, 2016
@david-caro david-caro deleted the add_package_extras_handling branch July 29, 2016 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants