WIP tests: repeated package different extras#6
WIP tests: repeated package different extras#6david-caro wants to merge 1 commit intoinveniosoftware:masterfrom
Conversation
* Adds a test to check the behavior when the same package is listed more than once with different extras selected. * Adds also ingnories for vim swapfiles. Signed-off-by: David Caro <david@dcaro.es>
b9c3d41 to
8613258
Compare
|
@david-caro can you keep the |
| 'click>=5.0.0', | ||
| 'mock>=1.3.0', | ||
| 'invenio-db[versioning]>=1', | ||
| 'invenio-db[versioning,mysql]>=1', |
There was a problem hiding this comment.
IMHO it's more complicated in real life. This case should never happen since it's obvious to fix. There might be however following case:
requirements = [
'invenio-db[versioning]>=1',
]
extras_require = {
'mysql': [
'invenio-db[mysql]>=1',
],
}
$ requirements-builder -e mysql ...
invenio-db[versioning,mysql]>=1There was a problem hiding this comment.
Yes, but now you see and are able to reproduce the issue, and most probably, the root of it is the same as the real-life example (still investigating).
There was a problem hiding this comment.
@david-caro When you re-push, please also add yourself to the AUTHORS.rst file, thanks!
There was a problem hiding this comment.
@david-caro IMHO we don't have to solve this limitation here since pip-compile already solves it for us.
There was a problem hiding this comment.
pip compile needs a requirements.txt file as input, the step from setup.py->requirements.txt is done by requirements-builder and that step is the one that's failing:
08:36 AM ~/Work/inveniosoftware/invenio-workflows<venv:invenio-workflows> (starting-point-invenio-3|…7)
dcaro@pcrcssis001$ grep invenio-db setup.py
'invenio-db[postgresql,versioning]>=1.0.0a9',
'invenio-db[mysql,versioning]>=1.0.0a9',
'invenio-db[versioning]>=1.0.0a9',
'invenio-db[versioning]>=1.0.0a9',
08:36 AM ~/Work/inveniosoftware/invenio-workflows<venv:invenio-workflows> (starting-point-invenio-3|…7)
dcaro@pcrcssis001$ requirements-builder -e mysql --level=min setup.py
blinker==1.4
flask-celeryext==0.1.0
Flask-CLI==0.2.1
invenio-db==1.0.0a9
invenio-files-rest==1.0.0a3
invenio-records-files==1.0.0a5
|
This does not make sense here anymore, as the issue is down the stack trace, on pip pypa/pip#3878 |
more than once with different extras selected.
Signed-off-by: David Caro david@dcaro.es