crossrefutils: urlencode encoding #3516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaplun
added
Type: bug
Component: MiscUtil
Component: BibEdit
Branch: maint-1.2
and removed
Status: in review
labels
kaplun
force-pushed
the
crossref-urlencode
branch
from
59d136b
to
b3d2a94
Compare
kaplun
force-pushed
the
crossref-urlencode
branch
2 times, most recently
from
1503354
to
71ca754
Compare
|
|
||
| query = urllib.urlencode({ | ||
| 'pid': pid, | ||
| 'noredirect': 'tru', |
* FIX Correctly urlencodes the query sent to CrossRef in order to retrieve information about a given DOI. * FIX Correctly passes the noredirect flag to CrossRef API. * NEW Supports querying CrossRef with free account (without password). (closes inveniosoftware#3503) (closes inveniosoftware#1277) Co-authored-by: Theodoropoulos Theodoros <[email protected]> Co-authored-by: Chokri Ben Romdhane <[email protected]> Signed-off-by: Samuele Kaplun <[email protected]>
kaplun
force-pushed
the
crossref-urlencode
branch
from
71ca754
to
79d25d1
Compare
tiborsimko
pushed a commit
to tiborsimko/invenio
that referenced
this pull request
Nov 22, 2016
* FIX Correctly URL-encodes the query sent to CrossRef in order to retrieve information about a given DOI. * FIX Correctly passes the noredirect flag to CrossRef API. * BETTER Supports querying CrossRef with free account (without password). (closes inveniosoftware#3503) (closes inveniosoftware#1277) (PR inveniosoftware#3516) Co-authored-by: Theodoropoulos Theodoros <[email protected]> Co-authored-by: Chokri Ben Romdhane <[email protected]> Signed-off-by: Samuele Kaplun <[email protected]>
|
Closed by #3725. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
retrieve information about a given DOI.
(closes BibEdit: import data with crossref #3503)
Reported-by: Chokri Ben Romdhane [email protected]
Signed-off-by: Samuele Kaplun [email protected]